atiaomar1978-hub commented on PR #26146: URL: https://github.com/apache/camel/pull/26146#issuecomment-5560496330
## Review fixes applied _AI-generated on behalf of atiaomar1978-hub_ Addressed findings from Bugbot and Grok review in commit `156e1db`: 1. **Stdout hygiene** — JBang now selects `log4j2-mcp-stdio.properties` (stderr Console) during `configureLogging`, before Log4j2 is initialized. 2. **CLI overrides profile** — `--mcp-stdio` uses `addOverrideProperty` so profile `camel.server.mcp-transport=http` cannot silently defeat the flag. 3. **`--mcp` exclusivity** — rejects both CLI `--mcp` and profile `camel.jbang.mcp=true`. 4. **Quiet printer** — profile-only stdio uses `mcpStdioMode`; `QuietPrinter.printErr` writes to stderr. 5. **Tests** — stdio unit tests use piped streams; real `applyMcpStdioRuntimeOptions` coverage added. Bugbot re-review: no remaining must-fix issues. All 16 related unit/IT tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
