oscerd commented on PR #26165: URL: https://github.com/apache/camel/pull/26165#issuecomment-5570988125
Thanks for the review. On the `ast-grep` hit for the two broad catches — your reading is right, and both are deliberate: - `OpaPolicyEvaluator.evaluate()` catches `Exception` rather than `OPAException` on purpose. Fail-closed has to hold regardless of which layer gave up, so a Jackson failure serializing the input document, or a type-converter failure building it, has to land in the same place as an unreachable OPA server. Narrowing it to `OPAException` would make an input-serialization bug bypass `failOpen` handling and surface as an unhandled runtime exception instead. There is a test for exactly that (`failsClosedWhenTheSdkFailsWithSomethingOtherThanAnOpaException`). - `OpaSecurityProcessor.process()` is the standard `DelegateAsyncProcessor` contract — set the exception on the exchange, call the callback, return true — so nothing to narrow there either. Addressed your javadoc point in 35f7c3e and replied on the `doStop()` thread with the reasoning for keeping the assignments. Both threads left open for you to resolve. _Claude Code on behalf of @oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
