oscerd commented on PR #26183:
URL: https://github.com/apache/camel/pull/26183#issuecomment-5582567261
Thanks @davsclaus @gnodet — both points addressed in e3f7d0a:
- **JUnit assertions**: switched `VertxHttpRestProducerHeaderFilterTest`
from AssertJ to JUnit (`assertEquals`/`assertNull`) to match the module's
existing style, including your `assertEquals("Hello World", out)` and the
`assertNull` suggestions for `Via`/`Cache-Control`.
- **Content-Type coverage**: added `Content-Type: application/json` to the
request and assert it **still reaches the server**. Exactly as you described —
it's in `HttpUtil.addCommonFilters`, but
`DefaultVertxHttpBinding.populateRequestHeaders` sets it explicitly from
`ExchangeHelper.getContentType()` before the filter loop runs, so it survives.
The test now pins that invariant (verified locally: it arrives as
`application/json`), so a future refactor that drops the explicit assignment
would fail here instead of silently breaking the most user-visible header.
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
