Croway commented on PR #26308:
URL: https://github.com/apache/camel/pull/26308#issuecomment-5634175403
Thanks for the review, all three points addressed in e3de79728884:
- **Recycling on throwing scripts**: the exhaustion check moved into the
finally block, so failed evaluations count and are measured too; new test
throwingScriptsCountTowardsRecycling locks it in.
- **run.endive:runtime** is now declared in the module pom with
`${endive-version}` (1.1.0, the version camel-wasm uses). quickjs4j 0.1.0 runs
on it: all 45 module tests pass with endive resolved at 1.1.0, so the two
components no longer depend on nearest-wins.
- **Docs**: the engine lifecycle section shows
`camel.language.quickjs.engineMaxMemory` / `engineMaxEvaluations` in
application.properties and the programmatic alternative; catalog mirror updated.
The two minor suggestions (guarded discard, volatile fields) are applied as
well.
_Claude Code on behalf of Croway_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
