Croway commented on PR #26309:
URL: https://github.com/apache/camel/pull/26309#issuecomment-5634295453

   Thanks, all points addressed in feb95873ac95 (the branch is now rebased on 
#26308, so GitHub shows its two commits until that one merges; this PR's change 
is the last commit):
   
   - **Selective discard**: only a trap (host function throwing, stack 
overflow, compile failing on a broken engine) drops the engine; a JavaScript 
exception keeps it. Exhaustion is checked in the finally block on both 
evaluation paths, so throwing evaluations still count towards recycling.
   - **Error classification**: compile failures are detected on their own 
message, and a trivial-function probe tells a bad script from a broken engine, 
so a valid expression is no longer reported as a syntax error after a trap.
   - **camel.getBody()** follows the body binding's rules for streaming bodies 
(explicit error), documented in the API table.
   - **Commit convention**: squashed into one `CAMEL-24688:` commit. 
`run.endive:runtime` is declared in #26308's commit that this PR sits on.
   
   62 tests in the module (7 new).
   
   _Claude Code on behalf of Croway_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to