hxxxi-malog commented on issue #6805:
URL: https://github.com/apache/camel-k/issues/6805#issuecomment-5652330598
Hi, I'd like to work on this issue if no one else has started yet. 🙂
I've looked into the codebase, and my plan would be:
1. **API definitions**: remove `LoggingTrait`, `MasterTrait` and
`TelemetryTrait` from `pkg/apis/camel/v1/trait/` and drop the corresponding
fields from the `Traits` struct in `common_types.go`.
2. **Trait implementations**: remove
`pkg/trait/{logging,master,telemetry}.go` and their unit tests, and unregister
them in `trait_register.go`.
3. **Generated code / CRDs**: re-run `make generate` to refresh the
generated deepcopy functions, apply configurations, trait descriptions
(`zz_desc_generated.go`, `zz_generated_doc.go`) and the CRD manifests in
`pkg/resources/config/crd/bases/` (integrations, pipes, integrationplatforms,
integrationprofiles).
4. **Tests**: update tests that still reference these traits (e.g.
`trait_configure_test.go`, `platform/defaults_test.go`, `cmd/run_test.go`), and
remove the related e2e tests (`e2e/common/traits/master_test.go`,
`e2e/telemetry/`).
5. **Docs**: remove
`docs/modules/traits/pages/{logging,master,telemetry}.adoc` and their
navigation entries.
Since all three traits were deprecated in 2.9.0 with migration paths already
documented (Quarkus properties / manual Role+RoleBinding for master), this
looks like a clean removal for the 2.12.0 milestone. Happy to adjust the plan
if maintainers prefer a different scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
