davsclaus opened a new pull request, #26390: URL: https://github.com/apache/camel/pull/26390
Prerequisite for [CAMEL-24713](https://issues.apache.org/jira/browse/CAMEL-24713): before the `camel_catalog_sample` fallback (`eip-samples.json`) can be generated from the user-manual pages with the build failing on an invalid example, the examples have to validate. Running `YamlValidator` over every `[source,yaml]` block starting with `- ` in `docs/user-manual/modules/ROOT/pages` gave 203 blocks, 36 invalid. After this PR: 186 valid; the 17 left are the old-syntax blocks of the upgrade guides, `camel-4-migration-guide`, `camel-jbang-transforming`, `camel-report-maven-plugin` (an ellipsis) and the two Antora-config blocks of `release-guide-website` / `improving-the-documentation`, which are deliberately not Camel YAML and will be excluded by the mojo. ### Doc fixes (11 pages, 18 blocks) | Page | What was wrong | |---|---| | `oncompletion.adoc` (4) | route scoped `onCompletion` written as a step: YAML has no route scope, so the example now uses a `routeConfiguration` the route refers to, with a sentence saying so; `executorServiceRef` → `executorService` | | `error-handler.adoc` (2) | `steps` at route level; route scoped `onException` as a step (the Java example is global, so top-level) and `redeliveryPolicy` as a step | | `exception-advanced.adoc`, `exception-handling-patterns.adoc`, `try-catch-finally.adoc` (3) | `redeliveryPolicy` / `onWhen` are properties of `onException` / `doCatch`, not steps; `beanType` → `type` | | `transformer.adoc` (3), `validator.adoc` (1) | `inputType` is a route property, not a step; `endpointTransformer` has no `parameters`, they go on the `uri` | | `routes.adoc` | `jaxb` needs `contextPath` | | `rest-dsl-openapi.adoc` | `bindingMode: true` is not in the enum → `json` (matches the Java example) | | `route-template-bean-binding.adoc` (2) | a template bean needs `type` (required in the model) | | `virtual-threads.adoc` | `threads` has no `steps`; the `to` follows it | ### YAML DSL: route `delayer` `delay-interceptor.adoc` was right, but `RouteDefinitionDeserializer` never exposed the `delayer` attribute that `RouteDefinition` has (`route.json` index 12). Added as a `string` property like the other duration options, schema regenerated in `camel-yaml-dsl` and the `camel-catalog` mirror, covered in `RoutesTest`. Verified: `RoutesTest` and the `camel-yaml-dsl-validator` test suite (90 tests) pass; a re-run of the validator over the user manual gives 186 ok / 17 intentionally invalid. _Claude Code on behalf of davsclaus_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
