tmielke commented on PR #26334: URL: https://github.com/apache/camel/pull/26334#issuecomment-5661643456
Thanks for the thorough reviews @Croway, @gnodet, @oscerd — the findings are all valid. Before addressing them, I want to raise the question of whether this fix should go into Camel at all, given the circumstances. Here are the trade-offs: **Option A: Fix in Camel (address review findings and ship the workaround)** Pros: - Users hitting this today (e.g. `camel run --runtime=quarkus` with HTTP routes) get a transparent fix without any endpoint configuration changes - No loss of compression — only brotli is excluded, gzip/deflate/others continue to work Cons: - It's a temporary workaround for an upstream bug — HttpClient already has the fix committed ([apache/httpcomponents-client@be07c77](https://github.com/apache/httpcomponents-client/commit/be07c77297576b08bc01bb93789eca6f5f9bf850)), pending release - The workaround has proven tricky to get right — this PR already has two critical bugs (over-broad activation affecting all Camel HTTP users, missing x-gzip alias causing `HttpException`) - Adds complexity that becomes dead code once Camel upgrades to a fixed HttpClient version (>= 5.6.5) - Replicating `ContentCompressionExec` internals (like the x-gzip alias) creates a fragile coupling to HttpClient's internal behavior **Option B: Don't fix in Camel — document workaround, wait for upstream** Pros: - No risk of regressions in camel-http's default compression path - Zero maintenance burden — the problem resolves itself when HttpClient ships the fix and Camel bumps the dependency - A simple user workaround exists today: `contentCompressionDisabled=true` on affected endpoints - Quarkus-side fix is also tracked ([quarkusio/quarkus#56547](https://github.com/quarkusio/quarkus/issues/56547)) Cons: - The user workaround disables *all* compression (not just brotli), causing a slight bandwidth overhead - Users need to know about the workaround and apply it to every affected endpoint - `camel run --runtime=quarkus` users may not have easy control over endpoint options - Unknown timeline for HttpClient 5.6.5 release _Claude Code on behalf of @tmielke_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
