davsclaus commented on code in PR #26397:
URL: https://github.com/apache/camel/pull/26397#discussion_r4003969662
##########
components/camel-keycloak/src/main/docs/keycloak-component.adoc:
##########
@@ -262,7 +263,9 @@ YAML::
- onException:
exception:
- "org.apache.camel.CamelAuthorizationException"
- handled: true
+ handled:
+ constant:
+ expression: "true"
Review Comment:
~~Suggestion withdrawn.~~ The form in the PR is the canonical YAML DSL
format (the explicit `expression:` wrapper), which is what the docs should use:
the shorthand is the deprecated classic form. Please keep it as written, sorry
for the noise.
_Claude Code on behalf of davsclaus_
##########
components/camel-kafka/src/main/docs/kafka-component.adoc:
##########
@@ -970,13 +970,16 @@ YAML::
+
[source,yaml]
----
+- onException:
+ exception:
+ - java.lang.Exception
+ handled:
+ constant:
+ expression: "false"
Review Comment:
~~Suggestion withdrawn.~~ The form in the PR is the canonical YAML DSL
format (the explicit `expression:` wrapper), which is what the docs should use:
the shorthand is the deprecated classic form. Please keep it as written, sorry
for the noise.
_Claude Code on behalf of davsclaus_
##########
components/camel-ai/camel-ai-resource/src/main/docs/ai-resource-component.adoc:
##########
@@ -101,9 +103,11 @@ YAML::
description: "Current application configuration"
mimeType: application/json
steps:
- - poll-enrich:
- uri: "file:config?fileName=app.json&noop=true&idempotent=false"
+ - pollEnrich:
timeout: 5000
+ expression:
+ constant:
+ expression:
"file:config?fileName=app.json&noop=true&idempotent=false"
Review Comment:
~~Suggestion withdrawn.~~ The form in the PR is the canonical YAML DSL
format (the explicit `expression:` wrapper), which is what the docs should use:
the shorthand is the deprecated classic form. Please keep it as written, sorry
for the noise.
_Claude Code on behalf of davsclaus_
##########
components/camel-elasticsearch/src/main/docs/elasticsearch-component.adoc:
##########
@@ -388,7 +388,8 @@ YAML::
scrollKeepAliveMs: 30000
- split:
expression:
- body: {}
+ simple:
+ expression: "${body}"
Review Comment:
~~Suggestion withdrawn.~~ The form in the PR is the canonical YAML DSL
format (the explicit `expression:` wrapper), which is what the docs should use:
the shorthand is the deprecated classic form. Please keep it as written, sorry
for the noise.
_Claude Code on behalf of davsclaus_
##########
components/camel-jdbc/src/main/docs/jdbc-component.adoc:
##########
@@ -250,18 +250,19 @@ YAML::
- route:
from:
uri: direct:hello
- steps:
- - to:
- uri: jdbc:testdb
- parameters:
- outputType: StreamList
- - split:
- expression:
- body: {}
- streaming: true
- steps:
- - to:
- uri: mock:result
+ steps:
+ - to:
+ uri: jdbc:testdb
+ parameters:
+ outputType: StreamList
+ - split:
+ expression:
+ simple:
+ expression: "${body}"
Review Comment:
~~Suggestion withdrawn.~~ The form in the PR is the canonical YAML DSL
format (the explicit `expression:` wrapper), which is what the docs should use:
the shorthand is the deprecated classic form. Please keep it as written, sorry
for the noise.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
