gnodet-bot commented on code in PR #26401:
URL: https://github.com/apache/camel/pull/26401#discussion_r4004084804
##########
dsl/camel-yaml-dsl/camel-yaml-dsl-common/src/main/java/org/apache/camel/dsl/yaml/common/YamlDeserializationContext.java:
##########
@@ -415,9 +415,10 @@ private Object construct(Node node, String id,
ConstructNode constructor) {
? e.getProblem().substring("Unsupported field: ".length())
: null;
String hint = "";
if ("bean".equals(field)) {
- hint = " (the bean language is written as method: {ref:
myBean, method: process})";
+ hint = " (the bean language is written as expression: {method:
{ref: myBean, method: process}})";
} else if ("expression".equals(field) || "language".equals(field))
{
- hint = " (an expression is written with the language as the
key: simple: \"...\", constant: \"...\")";
+ hint = " (an expression is written as expression: with the
language as the key: expression: {simple:"
+ + " {expression: \"...\"}}, expression: {constant:
{expression: \"...\"}})";
Review Comment:
💡 **Nit:** "written as expression: with the language as the key" is hard to
parse — "as expression:" looks like it ends the thought, then "with" restarts
it. Rewording to make the structure clearer:
```suggestion
hint = " (an expression is written with the expression:
wrapper and the language as the key: expression: {simple:"
+ " {expression: \"...\"}}, expression: {constant:
{expression: \"...\"}})";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
