gnodet commented on PR #26330: URL: https://github.com/apache/camel/pull/26330#issuecomment-5660363304
Addressed all review findings in e3de1ab89dd7: 1. **test-bundles phase ordering** — moved `copy-legal` from `generate-resources` to `initialize` so `legal.xml` is in place before `remote-resources:process` runs, regardless of plugin merge order when dep-check profile is active. 2. **setup-java v6.0.0** — pinned to the same commit hash used by all other workflows. 3. **Removed `-q` and `|| true`** — warnings are now visible in the report, and genuine build failures will surface (non-blocking via `continue-on-error: true`). 4. **fetch-depth: 1** — full history not needed for dependency analysis. 5. **JUnit ignores** — added `junit-jupiter` to unused-declared and `junit-jupiter-api` to used-undeclared ignore lists. RE: non-blocking suggestions from the review: - **CI cost / schedule trigger** — good point, open to switching to `schedule:` + `workflow_dispatch` if the per-PR cost is too high. Left as-is for now since it's still non-blocking. - **`failOnWarning` property naming** — noted; can namespace it in a follow-up if preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
