oscerd commented on PR #3030:
URL: https://github.com/apache/camel-kamelets/pull/3030#issuecomment-5665031802

   Thanks @yuvalif — that capture is exactly what was needed, and it settled 
the one thing this PR had to leave open.
   
   Running your payload through the branch:
   
   ```
   id=[1789392761.006254.5eb63bbbe01eeed093cb22bb8f5acdc3]
   opaque=[my-opaque-data-value-123]
   meta=[[{key=x-amz-meta-author, val=yuval}, {key=x-amz-meta-project, 
val=ceph-rgw}]]
   tags=[[{key=env, val=test}, {key=team, val=rgw}]]
   ce-id=[1789392761.006254.5eb63bbbe01eeed093cb22bb8f5acdc3]
   ```
   
   All four headers populate, and `metadata` and `tags` come through as 
structured lists rather than flattened strings.
   
   **On `eventId`.** I had written a caveat into the documentation saying Ceph 
may emit it empty, so deduplicating on it might silently do nothing — taken 
from the event structure in your docs, which shows `"eventId":""`. Your capture 
shows it is populated, `<timestamp>.<counter>.<etag>` and unique per event, so 
the caveat was wrong and the empty value in the docs sample is just a 
placeholder. Removed it, and the documentation now describes the real format.
   
   **One correction to my own wording.** I had described tags as being "in a 
more structured form than the metadata", following your note on #3026. Your 
capture shows both arrive in the same `[{key, val}]` shape, so that was 
misleading and is now fixed.
   
   **One thing your capture does not cover, which I checked separately.** Your 
object had metadata, tags and opaque data all set. I built the inverse — those 
three keys deleted — and the route fails with `PathNotFoundException` rather 
than emitting empty headers. I did not treat that as a bug to fix, because the 
documented event structure carries all four keys always and merely leaves them 
empty when nothing is set, which your capture is consistent with. So a payload 
missing them is not a Ceph notification, and failing is the same behaviour the 
Kamelet already has for any foreign message on the topic.
   
   If RGW can in fact omit those keys in some configuration or older release, 
that assumption is wrong and the JSONPath steps should suppress the exception 
instead — worth saying so if you know of such a case.
   
   Documentation-only change on top of the reviewed commit; the Kamelet 
template is unchanged.
   
   ---
   _Claude Code on behalf of Andrea Cosentino_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to