oscerd opened a new pull request, #3036: URL: https://github.com/apache/camel-kamelets/pull/3036
Follow-up to #3032, picking up the first review note @davsclaus left there: only `kafka-source` got the mapping, while the sibling single-record sources have the same gap. ## What this adds The same block as #3032, on four more Kamelets: - `kafka-apicurio-registry-not-secured-source` - `kafka-azure-schema-registry-source` - `kafka-not-secured-apicurio-registry-source` - `kafka-not-secured-apicurio-registry-json-source` ``` kafka-topic ce-kafkatopic from CamelKafkaTopic kafka-key ce-kafkakey from CamelKafkaKey kafka-partition ce-kafkapartition from CamelKafkaPartition kafka-offset ce-kafkaoffset from CamelKafkaOffset kafka-timestamp ce-kafkatimestamp from CamelKafkaTimestamp ``` All four had a byte-identical template tail to `kafka-source`, so the block lands at the same anchor in each. Purely additive — the `CamelKafka*` headers stay on the exchange. ## Why the batch sources are excluded `kafka-batch-source`, `kafka-batch-apicurio-registry-source`, `kafka-batch-apicurio-registry-not-secured-source` and `kafka-batch-azure-schema-registry-source` run the consumer with `batching: true`, so the body is a list of records. There is no single record whose topic, partition or offset the headers would describe, and mapping them there would be misleading rather than useful. @davsclaus drew the same line in the review. ## Verified These four have no Citrus tests — they need a live Apicurio or Azure Schema Registry — so I loaded all four templates into one Camel context and drove a record through each: ``` PROBE kafka-apicurio-registry-not-secured-source t=[orders] k=[k-7] p=[3] o=[42] ts=[1789392761000] ce=[orders] PROBE kafka-azure-schema-registry-source t=[orders] k=[k-7] p=[3] o=[42] ts=[1789392761000] ce=[orders] PROBE kafka-not-secured-apicurio-registry-source t=[orders] k=[k-7] p=[3] o=[42] ts=[1789392761000] ce=[orders] PROBE kafka-not-secured-apicurio-registry-json-source t=[orders] k=[k-7] p=[3] o=[42] ts=[1789392761000] ce=[orders] ``` The behaviour itself is already covered end to end against a real broker by the strengthened `kafka-source-pipe-test` in #3032. `script/validator` reports no errors, the doc generator produces no diff beyond the partials, and `KameletsCatalogTest` passes (18 tests). ## Ordering Independent of #3032 — different files, no overlap — but it reads better merged after it, since the rationale lives there. --- _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
