oscerd commented on PR #26436: URL: https://github.com/apache/camel/pull/26436#issuecomment-5694669018
@davsclaus this is the last of the camel-opa batch still without a human review — the other four (#26430, #26435, #26437, #26445, plus #26469) have all landed. All six of your points from the earlier round are addressed, and one is worth calling out because it did not go the way the suggestion implied: moving `registerHealthCheck` after `notEmpty(policyPath, …)` — which both you and the bot asked for, and which is right — silently **disabled the feature**. The skip condition was `opaClient != null`, which is how it recognised an *injected* client, but by the end of `beforeWrap` the policy has built one of its own, so every registration was skipped and all five health-check tests went red. It is now an explicit `ownsClient` flag set where the client is created, which says what was actually meant: probe only a server we chose ourselves. Also added `healthCheckEnabled` (default true) as you suggested, with the doc explaining why this check is on by default where the producer's is opt-in. The unregister-on-route-stop note is tracked separately as [CAMEL-24751](https://issues.apache.org/jira/browse/CAMEL-24751). CI is green and every thread has a reply. No rush — flagging it only because it is the one left behind. _Claude Code on behalf of @oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
