davsclaus opened a new pull request, #26532:
URL: https://github.com/apache/camel/pull/26532

   Follow-up to CAMEL-24659 / CAMEL-24699. Covers items 2 and 3 of 
[CAMEL-24661](https://issues.apache.org/jira/browse/CAMEL-24661); `--console` 
for Spring Boot and Quarkus (item 1) will be a separate PR.
   
   ## What
   
   **Execution limits reach the exported Quarkus and Spring Boot runs.** `camel 
run foo.yaml --runtime=quarkus|spring-boot` only passed `--jvm-args` and 
`--jfr` to the child JVM, so `--max-seconds`, `--max-messages` and 
`--max-idle-seconds` were silently ignored. The existing-project path (`camel 
run pom.xml`, CAMEL-24699) and the Camel Main run already forwarded them. The 
`-Dcamel.main.durationMax*` properties are now built once in 
`buildDurationLimitArgs()` and used by every run path; 
`buildExportedRunJvmArgs()` assembles the `jvm.args` / 
`spring-boot.run.jvmArguments` value for the exported runs.
   
   **The Quarkus run log file is named after the name the application 
reports.** `runQuarkus()` wrote `~/.camel/<--name>.log`, and `--name` defaults 
to `CamelJBang`. The export derives the real name from the first route file and 
writes it as `camel.main.name`, which is the name the application reports to 
`camel ps`. `camel log` and the TUI Log tab look for `<reported name>.log`, so 
for a Quarkus run without an explicit `--name` they found nothing (the empty 
Log tab mentioned in the issue). The name is now read back from the exported 
`application.properties` via `resolveExportedAppName()`, the same as the Camel 
Main run does. Spring Boot is unaffected as it logs to `<pid>.log`.
   
   ## Tests
   
   New `RunExportedProjectTest` covers the JVM args builder (limits alone, 
merged with `--jvm-args`, with `--jfr`, none), that the limits are the same 
across the export and existing-project paths, and the app name resolution. 
`RunExistingProjectTest` and `RunTest` still pass; the camel-jbang-core module 
was built with `mvn install`.
   
   ## Docs
   
   `camel-jbang-running.adoc`: the Runtimes section now lists the options 
passed to all three runtimes and how the log file is named.
   
   _Claude Code on behalf of davsclaus_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to