gnodet-bot commented on code in PR #26535:
URL: https://github.com/apache/camel/pull/26535#discussion_r4034548994
##########
components/camel-huawei/camel-huaweicloud-smn/src/main/java/org/apache/camel/component/huaweicloud/smn/SimpleNotificationProducer.java:
##########
@@ -307,17 +306,8 @@ private void validateServiceConfigurations(
if (LOG.isDebugEnabled()) {
LOG.debug("Inspecting exchange body");
}
Review Comment:
🔧 **Nit — stale debug message:** `LOG.debug("Inspecting exchange body")`
fires here at the top of the method, before the operation is resolved. After
the reordering it now immediately precedes `LOG.debug("Inspecting operation
name")`, which makes the log sequence misleading (`Inspecting exchange body` →
`Inspecting operation name` → [operation resolved] → [body checked]). Move this
`if (LOG.isDebugEnabled()) { LOG.debug("Inspecting exchange body"); }` block
down to just before the body-check `if (ObjectHelper.isEmpty(...))` so the log
trail matches the actual execution order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
