oscerd opened a new pull request, #3044: URL: https://github.com/apache/camel-kamelets/pull/3044
Third tranche of #2873, after #3040 and #3041. Eight Pipes across `kafka/`, `jira/` and `slack/`. These are one Citrus test per integration, like `transformation/` in #3040, so the file, the Citrus file name and the test name all move from `<name>-pipe` to `<name>-route`. ## Salesforce was meant to be in this tranche and is deliberately left out Its three Pipes are driven by `salesforce-sink.feature`, a **Camel K cluster test** written in Gherkin: ```gherkin Given load Pipe timer-to-salesforce-pipe.yaml Then Camel K integration timer-to-salesforce-pipe should be running ... Given delete Pipe timer-to-salesforce-pipe ``` Those steps take Pipe resources and deploy them to a cluster. Converting the files would break the feature rather than migrate it, and it is `@ignored` anyway. ## A sharper rule for what is convertible Finding that gave a better criterion than the shape based one I used in the earlier PRs: > A Pipe is convertible exactly when a `.citrus.it.yaml` references it. Checking every Pipe against that, **five are not referenced**: ``` aws/s3/aws-s3-to-knative-broker.yaml aws/s3/knative-to-log.yaml salesforce/direct-to-salesforce-update-pipe.yaml salesforce/direct-to-salesforce-delete-pipe.yaml salesforce/timer-to-salesforce-pipe.yaml ``` and all five are driven by `.feature` files using the Camel K steps — the two Knative ones by `aws-s3-knative-broker.feature` and `aws-s3-knative-cloudevents.feature`. **So the convertible total is 35, not the 38 I stated in #3040 and #3041.** I have corrected those two PR bodies. ## Verified Kafka and Slack pass locally: ``` ✔ SUCCESS (20360ms) kafka-router-route-test ✔ SUCCESS (21170ms) kafka-source-route-test ✔ SUCCESS (17535ms) kafka-sink-route-test ✔ SUCCESS (16130ms) slack-source-route-test ✔ SUCCESS (15742ms) slack-sink-route-test ``` **The three Jira tests fail in my environment — and they fail identically on an unmodified `main`**, same `jiraServer.inbound` 120s timeout, 0 of 3. So it is this machine, not the migration. They pass in CI (69 of 69 on #3040's run), which is where they will actually be checked here. Every conversion is also checked structurally: a verifier parses the Pipe and the generated route and compares the endpoint chain and every property, so a dropped or altered value fails rather than passing quietly. ## One naming wart `kafka-router-pipe-test` becomes `kafka-router-route-test`, which reads awkwardly. I kept the mechanical rule for consistency rather than special casing it, but `kafka-router-test` is a one line change if you prefer it. ## Progress 23 of 35 done. Remaining: the 12 singles — counter, crypto, earthquake, filter (2), header, http (2), log, mail, openapi, timer. --- _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
