gnodet commented on code in PR #26534:
URL: https://github.com/apache/camel/pull/26534#discussion_r4034754117
##########
.github/actions/incremental-build/incremental-build.sh:
##########
@@ -526,29 +547,24 @@ writeScalpelComparison() {
echo "" >> "$comment_file"
fi
- # Show Scalpel-detected change details
- if [ -n "$scalpel_props" ]; then
- echo "Changed properties: ${scalpel_props}" >> "$comment_file"
- echo "" >> "$comment_file"
- fi
- if [ -n "$scalpel_managed_deps" ]; then
- echo "Changed managed dependencies: ${scalpel_managed_deps}" >>
"$comment_file"
- echo "" >> "$comment_file"
- fi
- if [ -n "$scalpel_managed_plugins" ]; then
- echo "Changed managed plugins: ${scalpel_managed_plugins}" >>
"$comment_file"
- echo "" >> "$comment_file"
- fi
-
- echo "**Skip-tests mode would test ${scalpel_test_count} modules**
(${scalpel_direct_count} direct + ${scalpel_downstream_tested} downstream),
**skip tests for ${scalpel_skip_count}** (generated code, meta-modules)" >>
"$comment_file"
-
- # Show which modules Scalpel would test
+ # Show which modules Scalpel would test, with per-module evidence
(explain=true)
if [ -n "$scalpel_would_test" ]; then
echo "" >> "$comment_file"
- echo "<details><summary>Modules Scalpel would test
(${scalpel_test_count})</summary>" >> "$comment_file"
+ echo "<details><summary>Modules Scalpel would test
(${scalpel_tested_count})</summary>" >> "$comment_file"
echo "" >> "$comment_file"
+ local report="target/scalpel-report.json"
Review Comment:
Fixed in e85c9d7a514c — report path is now an explicit parameter to
`writeScalpelComparison` (third argument), passed from the call site which
already has the correct CWD-relative path from `runScalpelDetection`.
##########
.github/actions/incremental-build/incremental-build.sh:
##########
@@ -490,20 +487,43 @@ writeScalpelComparison() {
only_current_count=$current_total
fi
- # One-line summary: what Scalpel would change
- local summary="Scalpel: ${scalpel_test_count} tested, ${scalpel_skip_count}
compile-only — current: ${current_total} all tested"
+ # N-of-M framing: use reactorModuleCount from report when available
+ local nm_suffix=""
+ if [ "$scalpel_reactor_count" -gt 0 ] 2>/dev/null; then
+ nm_suffix=" of ${scalpel_reactor_count}"
+ fi
+
+ # One-line summary with N-of-M framing
+ local summary="Scalpel: ${scalpel_tested_count}${nm_suffix} tested,
${scalpel_skip_count} compile-only — current: ${current_total} all tested"
echo "" >> "$comment_file"
echo "---" >> "$comment_file"
echo "" >> "$comment_file"
echo "<details><summary>:microscope: Scalpel shadow comparison —
${summary}</summary>" >> "$comment_file"
echo "" >> "$comment_file"
- echo "[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected
**${scalpel_total} affected modules** (current approach: ${current_total})." >>
"$comment_file"
+ echo "[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected
**${scalpel_total}${nm_suffix} affected modules** (current approach:
${current_total})." >> "$comment_file"
echo "" >> "$comment_file"
- # Show modules only Scalpel found (not in current reactor)
+ # Show Scalpel-detected change details
Review Comment:
Fixed in e85c9d7a514c — `nm_suffix` is now only appended to
`scalpel_tested_count` (the N-of-M that makes sense: tested out of reactor).
`scalpel_total` (affected = tested + compile-only) is left as a plain count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
