oscerd opened a new pull request, #3045:
URL: https://github.com/apache/camel-kamelets/pull/3045

   Final tranche of #2873, after #3040, #3041 and #3044. The twelve remaining 
single Pipes: counter, crypto, earthquake, the two filters, header, the two 
http ones, log, mail, openapi and timer.
   
   **After this every Pipe that a Citrus test references has been migrated.**
   
   ## Three did not fit the rename
   
   **`earthquake-to-http.yaml` and `http-source-to-http.yaml`** carry no 
`-pipe` in their names, and neither do their Citrus files or test names. Only 
the contents change. Renaming them to `-route` would churn three names each to 
say what the filename already says.
   
   **`openapi`** has one Pipe driven by *two* Citrus tests, named after their 
scenario (`rest-openapi-sink-add-pet`, `...-delete-pet`) rather than after the 
Pipe. So the integration file is renamed to `rest-openapi-sink-route.yaml` and 
the references in both tests follow, while the Citrus file names and test names 
stay put.
   
   The other nine are the plain 1:1 rename.
   
   ## What remains as Pipes, and why
   
   ```
   aws/s3/aws-s3-to-knative-broker.yaml
   aws/s3/knative-to-log.yaml
   salesforce/direct-to-salesforce-update-pipe.yaml
   salesforce/direct-to-salesforce-delete-pipe.yaml
   salesforce/timer-to-salesforce-pipe.yaml
   ```
   
   All five are driven by `.feature` files whose Camel K steps (`load Pipe`, 
`Camel K integration <name> should be running`, `delete Pipe`) take Pipe 
resources. Converting them would break those features rather than migrate them.
   
   I verified none of the five is referenced by any `.citrus.it.yaml`, and that 
no referenced Pipe is left anywhere in the tree.
   
   ## Verified
   
   ```
   TOTAL:    37
   PASSED:   37 (100.0%)
   FAILED:   0 (0.0%)
   ```
   
   `./mvnw clean verify -pl :camel-kamelets-itest -Denable.integration.tests 
-Dit.test='CommonIT,MailIT,OpenApiIT'` — covering every Kamelet migrated here, 
and re-confirming the `transformation` ones from #3040 along the way.
   
   Every conversion also passes the structural verifier used across this 
series: parse both files, compare the endpoint chain and every property.
   
   ## One thing left alone
   
   Two test names still read `-pipe` — `aws-s3-uri-pipe-test` and 
`aws-sqs-uri-pipe-test` — but they already point at `-route.yaml` files. Stale 
names predating this work, in a directory this series does not touch, so I left 
them rather than widen the diff. Easy follow-up if you want the names tidied.
   
   ---
   _Claude Code on behalf of Andrea Cosentino_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to