gnodet-bot commented on code in PR #26551:
URL: https://github.com/apache/camel/pull/26551#discussion_r4037808998
##########
dsl/camel-jbang/camel-jbang-core/src/main/resources/known-plugins.json:
##########
@@ -9,12 +9,12 @@
"vendor": "Community"
},
{
- "name": "camel-kit",
+ "name": "kit",
"command": "kit",
"description": "Design Apache Camel Integrations with AI",
"firstVersion": "4.10.0",
"groupId": "io.github.luigidemasi",
- "artifactId": "camel-kit-jbang-plugin",
+ "artifactId": "camel-jbang-plugin-kit",
Review Comment:
✅ Correct fix — follows the `camel-jbang-plugin-<command>` naming convention
used by all other known plugins (e.g. `camel-jbang-plugin-forage`). The old
artifact ID `camel-kit-jbang-plugin` would have caused the Maven download to
fail.
⚠️ **Missing regression test:** `PluginAddTest` has no case for `camel
plugin add kit`. Please add one that asserts the resolved `dependency` in the
saved plugin config contains `io.github.luigidemasi:camel-jbang-plugin-kit`.
Without it, this exact bug (wrong artifact name) can silently regress.
##########
dsl/camel-jbang/camel-jbang-core/src/main/resources/known-plugins.json:
##########
@@ -9,12 +9,12 @@
"vendor": "Community"
},
{
- "name": "camel-kit",
+ "name": "kit",
Review Comment:
✅ Correct fix — `findKnownPlugin(name)` matches this field
case-insensitively. With the old value `"camel-kit"`, `camel plugin add kit`
could not find this entry and silently skipped the groupId/artifactId from the
registry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
