oscerd commented on PR #3046:
URL: https://github.com/apache/camel-kamelets/pull/3046#issuecomment-5716712841
Thanks @claudio4j — all three fixed in 90a1049ad.
**Makefile `generate`.** It invoked the deleted code, and removing those two
lines also had to fix the step after them: the target used to `cd
../script/generator`, then reach back with `cd ../../crds`. With the generator
gone it stays in `crds` and calls `./gen_crd/gen_crd_api.sh` directly. Checked
with `make -n generate`. I added a note that `nav.adoc` comes from the Maven
build now.
```make
# nav.adoc is generated by the Maven build, see the install target
generate:
cd crds && \
./gen_client.sh && \
./generate.sh && \
./gen_crd/gen_crd_api.sh
```
**The two stale descriptions.** `AGENTS.md` said Go is required for the
"`script/` and `crds/` generators" and described `script/` as the "Go doc
generator + YAML validator"; `security-model.adoc` listed `script/` as "(Go
generator/validator)". All now say validator.
**Why I missed them.** My sweep searched for the literal string
`script/generator` restricted to Markdown and YAML. That matches none of the
three: the Makefile was not in the file types I searched, and both prose
mentions describe the directory without naming the path. I have re-run it as a
case-insensitive search for the path, `generator.go`, "doc generator" and
"generator/validator" across every file type. What is left is the CHANGELOG,
which is release history and should not be rewritten, and the new mojo's own
javadoc line saying which Go code it replaces.
Nothing about the generated output changed: `nav.adoc` is still 264 lines
and 9078 bytes and does not appear in `git status` after a full build.
---
_Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
