gnodet-bot commented on PR #26603:
URL: https://github.com/apache/camel/pull/26603#issuecomment-5732697466

   **No test covers the bulkhead-with-fallback counter path.**
   
   Both `FaultToleranceCallCountersTest` and `ResilienceCallCountersTest` test:
   - open-breaker + fallback (`testFallbackAndRejectedCounters`)
   - timeout + fallback (`testTimedOutCounter`)
   
   But neither tests a full bulkhead + fallback scenario — the most interesting 
combination since `bulkheadRejectedCalls` is incremented from the 
`FallbackTask` in that case (not from the outer catch). The 
`testShowsFaultToleranceCountersAndBulkheadColumn` in `ListCircuitBreakerTest` 
only validates JSON serialization against hardcoded values, not actual counter 
behavior.
   
   Consider adding a `testBulkheadRejectedWithFallbackCounter()` test to each 
processor test class.
   
   _This review was generated by an AI agent, Hermès on behalf of @gnodet._
   <!-- reviewer: gnodet-bot -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to