harshilv17 commented on issue #6828: URL: https://github.com/apache/camel-k/issues/6828#issuecomment-5734938177
I'd like to pick this up. I've mapped the full reference graph and have one scoping question before opening a PR. Clearly in scope, as far as I can tell: - `pkg/controller/synthetic` (whole package) and `pkg/controller/integration/monitor_synthetic.go` - the `CAMEL_K_SYNTHETIC_INTEGRATIONS` lookup in `pkg/cmd/operator/operator.go` - `IntegrationSyntheticLabel` and `Integration.IsSynthetic()`, plus the seven trait guards and the `syntheticActions` wiring that depend on it - `trait.NewSyntheticEnvironment` and `getCamelAppObject`, which have no other callers - `docs/modules/ROOT/pages/running/synthetic.adoc`, its `nav.adoc` entry, and the env var row in `installation/advanced/advanced.adoc` Two things came up while tracing it. **`IntegrationKit.IsSynthetic()` looks already dead.** `IntegrationKitTypeSynthetic` is never assigned anywhere in the tree, only compared against inside `IsSynthetic()`. So the deprecated synthetic-Kit branches in `integrationkit/monitor.go`, `error.go`, `integrationkit_controller.go`, `camel.go` and `jvm.go` — all currently carrying `//nolint: staticcheck` — are unreachable today, independent of the env var. I'd fold those into the same PR unless you'd prefer they stay. **The actual question: is the external-app import path in scope?** `IntegrationImportedKindLabel` and `IntegrationImportedNameLabel` are only ever written by `pkg/controller/synthetic/synthetic.go`, so once that package goes, `initializeAction.importFromExternalApp` and `getCamelAppImportingCondition` in `pkg/controller/integration/initialize.go` become unreachable as well. Removing them follows from "clean all related business logic", but if importing external apps is something you want to keep as its own feature I'll leave that path alone. Minor docs note: every CRD and `camel-k-crds.adoc` occurrence of "synthetic" traces back to the single doc comment on `ContainerTrait.Image` (which describes the synthetic *Kit*), so that side is one comment plus `make generate`. I'd leave the mention in `observability/dashboard.adoc` as is, since it's describing where the Camel Dashboard project came from rather than documenting this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
