davsclaus opened a new pull request, #93:
URL: https://github.com/apache/camel-jbang-examples/pull/93
A cleanup pass over the ladder restructure, after walking through every
example.
## Mechanical
- The `## Install Camel CLI` heading in 29 READMEs held only an HTML comment
pointing at `install.adoc`, so it rendered as an empty section. It is now a
one-line link to the root README's install section; `install.adoc`, referenced
by nothing, is removed.
- `generate-catalog.sh`: the group READMEs only promise "how to run its
test" where every example in the group has one; the *Needs* column takes a
free-text `needs` from `metadata.json` instead of mapping `ciSkip` to "a local
model". `openai-pii-redaction` now says it needs an OpenAI-compatible API (it
said *nothing*), `docling-langchain4j-rag` that it needs a local model; both
are `ciSkip`.
- `AGENTS.md` still described the flat layout ("one example per top-level
directory, e.g. `mqtt/`"); it now describes the ladder, the README shape, and
the checklist ends with `./generate-catalog.sh`. CI runs Temurin 21, not 17.
## quick-start on the ladder
The four quick-start examples were the old material: 2022-style READMEs
(JBang install boilerplate, a stale `tree/main/routes` URL), no tests, while
the group README promised both. They now have the ladder-shaped README, a
Citrus test each (wired into the CI matrix), and `routes/` calls a plain POJO
`Greeter.greet(String)` instead of a `Processor`, which is the better first
step from YAML into Java.
## READMEs reshaped
`camel-1-tribute` (keeping the 2007 history and comparison table),
`keycloak-security-rest` (console setup compressed to four steps),
`openai-pii-redaction` (its "Expected Output" had sentiment-analysis lines
pasted in from the Watson example) and `docling-langchain4j-rag`. The three
that cannot run in CI now say so instead of promising a test.
## Two bugs in docling-langchain4j-rag
- The `chatModel` bean was dropped by 60a70d8 (the canonical-format pass),
so every `langchain4j-chat` step referenced a bean that did not exist and the
example could not start. Restored in the builder style `langchain4j-chat` uses;
verified the application starts with the model autowired.
- The batch timer had `delay` but no `period` and `repeatCount: 0`, so it
fired every second forever; it now has `batch.period` (hourly). `documents/`
and `output/` are git-ignored.
The PII route's `systemMessage` is a folded block now, so `camel validate
yaml --canonical` is clean on every ladder route.
_Claude Code on behalf of Claus Ibsen_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
