harshilv17 commented on issue #6836:
URL: https://github.com/apache/camel-k/issues/6836#issuecomment-5748497774
Working on this — the removal is already implemented in #6834.
That PR was opened for #6828 (Synthetic Integrations) and, as @squakez
spotted there, it also takes out the synthetic **Kit** logic: the
`IntegrationKitTypeSynthetic` constant, `(*IntegrationKit).IsSynthetic()`, the
skips in `integrationkit/initialize.go`, `error.go`, `monitor.go` and
`integrationkit_controller.go`, the `SyntheticKitDeprecated` condition, and the
two trait call sites. I posted a file-by-file audit against this issue's
requirements on #6834.
If you would rather have it as its own PR I can split it out, but one thing
is worth knowing before that call: two of the call sites are single boolean
expressions mixing both concepts.
```go
// pkg/trait/jvm.go:80
if ((e.Integration != nil && !e.Integration.IsManagedBuild()) ||
(e.IntegrationKit != nil && e.IntegrationKit.IsSynthetic())) &&
t.Jar == "" {
// pkg/trait/camel.go:95
if (e.Integration != nil && (!e.Integration.IsManagedBuild() ||
e.Integration.IsGitBuild())) ||
(e.IntegrationKit != nil && e.IntegrationKit.IsSynthetic()) {
```
So a split means both PRs editing the same `if`, and whichever merges second
rebases on a line that carries real semantics. In both cases the surviving
disjunct is the `!IsManagedBuild()` one, which is the replacement concept —
that coupling is why they came out together.
Happy either way, just say which you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
