gnodet-bot commented on code in PR #26626:
URL: https://github.com/apache/camel/pull/26626#discussion_r4056837302
##########
core/camel-support/src/main/java/org/apache/camel/support/MessageHelper.java:
##########
@@ -53,8 +53,8 @@
*/
public final class MessageHelper {
- private static final String MESSAGE_HISTORY_HEADER = "%-40s %-30s %-50s
%-12s";
- private static final String MESSAGE_HISTORY_OUTPUT = "%-40.40s %-30.30s
%-50.50s %12.12s";
+ private static final String MESSAGE_HISTORY_HEADER = "%-40s %-30s %-50s
%-12s %-32s %-9s";
+ private static final String MESSAGE_HISTORY_OUTPUT = "%-40.40s %-30.30s
%-50.50s %12.12s %-32.32s %9.9s";
Review Comment:
⚠️ **Separator mismatch — 43 chars short**
The format strings now produce a 178-char-wide table
(40+1+30+1+50+1+12+1+32+1+9), but the three separator lines in
`doDumpMessageHistoryStacktrace` are still 135 chars — the exact width of the
old 4-column layout. The table content will overflow the separator by 43
characters.
```suggestion
private static final String MESSAGE_HISTORY_HEADER = "%-40s %-30s %-50s
%-12s %-32s %-9s";
private static final String MESSAGE_HISTORY_OUTPUT = "%-40.40s %-30.30s
%-50.50s %12.12s %-32.32s %9.9s";
```
The suggestion above is a no-op (the format strings are already correct).
The actual fix is to update the three `-------...-------` literal strings in
`doDumpMessageHistoryStacktrace` from 135 to 178 dashes:
```
// was (135 dashes):
"---------------------------------------------------------------------------------------------------------------------------------------"
// should be (178 dashes — matches new table width):
"------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------"
```
There are three occurrences in `doDumpMessageHistoryStacktrace` (lines ~771,
~847, ~855 in the new file).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
