gnodet-bot commented on code in PR #26632: URL: https://github.com/apache/camel/pull/26632#discussion_r4057374143
########## dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/test/java/org/apache/camel/dsl/yaml/validator/YamlValidatorScalarLeniencyTest.java: ########## @@ -14,198 +14,3 @@ * See the License for the specific language governing permissions and * limitations under the License. */ Review Comment: ⚠️ **Test regression — all tests deleted.** See the comment on `YamlValidatorExpressionHintTest.java` for details. Only 3–4 of the tests here used a top-level `- from:` and needed updating; the rest (all scalar leniency cases, all rejection-boundary cases) can be restored without changes. ########## dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/test/java/org/apache/camel/dsl/yaml/validator/YamlValidatorExpressionHintTest.java: ########## @@ -14,126 +14,3 @@ * See the License for the specific language governing permissions and * limitations under the License. */ Review Comment: ⚠️ **Test regression — all tests deleted.** This file is now an empty compilation unit (just the license block). All test methods that were in `YamlValidatorExpressionHintTest` are gone: - `testHandledAsPlainValue` — expression hint for `handled: true` - `testContinuedAsPlainValue` — expression hint for `continued: "true"` - `testAggregateCompletionSizeAsPlainValue` — expression hint for `completionSizeExpression: 10` (this one used a top-level `- from:` in its YAML string) - `testExpressionFormIsAccepted` — explicit form passes both validators Only `testAggregateCompletionSizeAsPlainValue` needed updating (replace `- from:` with `- route:` + `from:` inside). The other three tests don't touch the compact notation at all and can be restored verbatim. Same situation applies to `YamlValidatorScalarLeniencyTest.java` — ~16 tests deleted, only 3 of them used a top-level `- from:` (`testStepsAsMapStillRejected`, `testWhenAsMapStillRejected`, `testScalarWhereStepsExpectedStillRejected`; `testRestGetAsMapStillRejected` used it in a non-route context). The others (`testQuotedBooleanAccepted`, `testNativeBooleanStillAccepted`, all placeholder tests, etc.) require no changes. Please restore the non-from tests verbatim, and update the 4 that used `- from:` to use `- route:\n from:` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
