gnodet-bot commented on code in PR #26638:
URL: https://github.com/apache/camel/pull/26638#discussion_r4058091136
##########
components/camel-file/src/main/java/org/apache/camel/component/file/FileConsumer.java:
##########
@@ -458,6 +458,10 @@ private void doCreateStartDirectory(File file) {
boolean created = operations.buildDirectory(file.getPath(), absolute);
if (!created) {
LOG.warn("Cannot auto create starting directory: {}", file);
+ } else {
Review Comment:
**[low] Log message is slightly redundant and awkward**
`"Created starting directory: {} (it did not exist): waiting for files"` —
"it did not exist" states the obvious (we just created it, so of course it
didn't exist). The double-colon structure is also a bit clunky. Consider a more
idiomatic phrasing:
```suggestion
LOG.info("Auto-created starting directory: {}; waiting for
files", file);
```
##########
components/camel-file/src/main/java/org/apache/camel/component/file/FileConsumer.java:
##########
@@ -458,6 +458,10 @@ private void doCreateStartDirectory(File file) {
boolean created = operations.buildDirectory(file.getPath(), absolute);
if (!created) {
LOG.warn("Cannot auto create starting directory: {}", file);
Review Comment:
**[low] Overly verbose inline comment**
The comment reads like a commit message or a PR description embedded in the
code — narrative, first-person, and longer than necessary. Code comments should
explain the *what/why* concisely. The Jira reference is useful; the rest can go:
```suggestion
// CAMEL-24855: promote to INFO so users see why the consumer is
waiting
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
