gnodet commented on code in PR #26486:
URL: https://github.com/apache/camel/pull/26486#discussion_r4059681422
##########
components/camel-xmlsecurity/src/main/java/org/apache/camel/dataformat/xmlsecurity/XMLSecurityDataFormat.java:
##########
@@ -793,15 +840,15 @@ public String getXmlCipherAlgorithm() {
}
public void setXmlCipherAlgorithm(String xmlCipherAlgorithm) {
- this.xmlCipherAlgorithm = xmlCipherAlgorithm;
+ this.xmlCipherAlgorithm = resolveAlgorithm(xmlCipherAlgorithm);
Review Comment:
Fixed in c8ceee61a82b — setters now store raw values; `resolveAlgorithm()`
is called lazily via private helpers at each crypto call-site.
##########
components/camel-xmlsecurity/src/main/java/org/apache/camel/dataformat/xmlsecurity/XMLSecurityDataFormat.java:
##########
@@ -793,15 +840,15 @@ public String getXmlCipherAlgorithm() {
}
public void setXmlCipherAlgorithm(String xmlCipherAlgorithm) {
- this.xmlCipherAlgorithm = xmlCipherAlgorithm;
+ this.xmlCipherAlgorithm = resolveAlgorithm(xmlCipherAlgorithm);
}
public String getKeyCipherAlgorithm() {
return keyCipherAlgorithm;
}
public void setKeyCipherAlgorithm(String keyCipherAlgorithm) {
- this.keyCipherAlgorithm = keyCipherAlgorithm;
+ this.keyCipherAlgorithm = resolveAlgorithm(keyCipherAlgorithm);
Review Comment:
Fixed in c8ceee61a82b — setters now store raw values; `resolveAlgorithm()`
is called lazily via private helpers at each crypto call-site.
##########
components/camel-xmlsecurity/src/main/java/org/apache/camel/dataformat/xmlsecurity/XMLSecurityDataFormat.java:
##########
@@ -861,15 +908,15 @@ public String getDigestAlgorithm() {
}
public void setDigestAlgorithm(String digestAlgorithm) {
- this.digestAlgorithm = digestAlgorithm;
+ this.digestAlgorithm = resolveAlgorithm(digestAlgorithm);
Review Comment:
Fixed in c8ceee61a82b — setters now store raw values; `resolveAlgorithm()`
is called lazily via private helpers at each crypto call-site.
##########
components/camel-xmlsecurity/src/main/java/org/apache/camel/dataformat/xmlsecurity/XMLSecurityDataFormat.java:
##########
@@ -861,15 +908,15 @@ public String getDigestAlgorithm() {
}
public void setDigestAlgorithm(String digestAlgorithm) {
- this.digestAlgorithm = digestAlgorithm;
+ this.digestAlgorithm = resolveAlgorithm(digestAlgorithm);
}
public String getMgfAlgorithm() {
return mgfAlgorithm;
}
public void setMgfAlgorithm(String mgfAlgorithm) {
- this.mgfAlgorithm = mgfAlgorithm;
+ this.mgfAlgorithm = resolveAlgorithm(mgfAlgorithm);
Review Comment:
Fixed in c8ceee61a82b — setters now store raw values; `resolveAlgorithm()`
is called lazily via private helpers at each crypto call-site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
