utafrali commented on code in PR #26673:
URL: https://github.com/apache/camel/pull/26673#discussion_r4060856730
##########
parent/pom.xml:
##########
@@ -316,7 +316,7 @@
<libthrift-version>0.24.0</libthrift-version>
<jodatime2-version>2.14.3</jodatime2-version>
<jolokia-version>2.6.2</jolokia-version>
- <jolt-version>0.1.8</jolt-version>
+ <jolt-version>1.3.0</jolt-version>
Review Comment:
Version jumps from `0.1.8` to `1.3.0`, which is more than a repackaging bump
upstream. Worth confirming in the PR description (or the upgrade guide) that
behavioural changes between the last bazaarvoice release and jolt-community
`1.3.0` (e.g. handling of `null` values, `Chainr` loader changes, JSON parser
defaults) don't silently alter transformation output for existing users. If the
existing `camel-jolt` tests are the only coverage, calling that out explicitly
would help reviewers gauge risk.
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -2349,3 +2349,13 @@ The `maxRetryTimeout` endpoint and component option is
deprecated in both `camel
it had no effect. The option is kept for backward compatibility of existing
endpoint URIs but is marked
deprecated and will be removed in a future release. Routes that set
`maxRetryTimeout` can simply drop it;
behaviour is unchanged.
+
+=== camel-jolt - switch from unmaintained bazaarvoice jolt to the
jolt-community fork
+
+The JOLT library dependency has been migrated from
`com.bazaarvoice.jolt:jolt-core` to
+`io.github.jolt-community.jolt:jolt-community-core`.
+See https://github.com/jolt-community/jolt-community[JOLT (Community Edition)].
+
+Due to the package rename from `com.bazaarvoice.jolt` to
`io.joltcommunity.jolt`, users who plug custom `Transform` or
+`ContextualTransform` classes into a Chainr spec need to update their imports
to `io.joltcommunity.jolt.Transform` and
+`io.joltcommunity.jolt.ContextualTransform`.
Review Comment:
The upgrade note only calls out `Transform` and `ContextualTransform`, but
the import change in `JoltEndpoint.java` shows that `Removr` also moved to a
sub-package (`io.joltcommunity.jolt.removr.Removr`) rather than a straight
`com.bazaarvoice.jolt` -> `io.joltcommunity.jolt` rename. Consider mentioning
that some classes (notably `Removr`) live in sub-packages now, so users doing a
blind package-prefix search-and-replace will get compile errors. Linking to the
jolt-community migration notes or listing the moved classes would help
downstream users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
