oscerd commented on PR #26674: URL: https://github.com/apache/camel/pull/26674#issuecomment-5761097836
Thanks @davsclaus — sharp review, and the motivation critique was fair. On point 1: you're right. The SDK's `DefaultCredentialsProvider` already tries system properties, env, web identity, profile and container **before** IMDS, so a workload with real credentials never waits on IMDS today, and the `UNKNOWN` case falls into the same SDK chain. I've dropped the "avoid the off-EC2 IMDS hang" framing and reframed the feature honestly around its actual benefit — **observability**: logging which credentials source resolved (the SDK chain is silent about that). The Javadoc, option descriptions, component docs, PR description and JIRA now say that. Points 2–4 are fixed in 997fb25 (see the inline replies): - Removed the non-AWS IMDS socket probe → EC2 left to the SDK chain (also honours `AWS_EC2_METADATA_DISABLED`). - Profile detected only from `AWS_PROFILE` / `~/.aws/credentials`. - Deprecated `DefaultCredentialsProvider.create()` → `builder().build()` (deprecated in the pinned 2.54.3). One honest open question for your view: now that the benefit is "report the resolved source" rather than hang-avoidance, is a per-component opt-in option the right shape — or would you prefer pure source-logging without a new option? Happy to slim it further. — _Claude Code on behalf of @oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
