oscerd opened a new pull request, #1842: URL: https://github.com/apache/camel-kafka-connector/pull/1842
## What Adds the `META-INF/services/` ServiceLoader manifests required by Kafka Connect's `plugin.discovery=service_load` mode (KIP-898), which is the default from Kafka Connect 4.0. Without them, CKC's connectors and SMTs aren't discovered in `service_load` mode (see #1633, #1734). ### Changes - **Generator**: each connector module now gets `META-INF/services/org.apache.kafka.connect.sink.SinkConnector` (or `.source.SourceConnector`) listing its generated connector class. Applied in **both** generators — `CamelKafkaConnectorKameletUpdateMojo` (kamelet-based) and `CamelKafkaConnectorUpdateMojo` (component-based). - **core**: manifests for the base `CamelSinkConnector` / `CamelSourceConnector` and for the concrete SMT (`Transformation`) implementations. - **camel-syslog** (hand-maintained, not generated): its sink and source manifests added directly. - **RAT**: exclude the generated Kafka Connect service manifests (matching the existing kie-server exclude). - Regenerated all connectors. ### Notes - The `Transformation` manifest lists **every concrete implementation the reflection scanner already discovered**, so `service_load` preserves the current plugin surface rather than changing it — a straight KIP-898 migration, not a behavior change. - Scope is CKC's own plugins. Third-party converters a user bundles (e.g. the Apicurio registry converters seen in #1633/#1734) ship their own manifests upstream and are out of scope here. - Validated by a new `ServiceLoaderManifestTest` in core (asserts every listed class exists, is public, non-abstract, and implements its SPI) plus the full regen build. Closes #1644. Refs #1633, #1734. _Claude Code on behalf of Andrea Cosentino._ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
