gnodet opened a new pull request, #26705: URL: https://github.com/apache/camel/pull/26705
## Summary Fix asymmetric `EXCLUSION_LIST` filtering in the Scalpel shadow comparison section of PR comments. ## Problem `writeScalpelComparison()` compared: - **Current reactor** (`current_reactor_ids`): already filtered through `EXCLUSION_LIST` - **Scalpel modules** (`scalpel_module_ids` / `scalpel_sorted`): **unfiltered** This caused modules in `EXCLUSION_LIST` (`camel-allcomponents`, `camel-catalog`, `apache-camel`, `docs`, `coverage`, `dummy-component`, `camel-jbang-*`, etc.) to appear as: - ⚠️ "Modules only in Scalpel" — wrongly alarming reviewers about modules that are intentionally excluded - "Modules Scalpel would test" — inflating the list with modules that will never be tested **Concrete example** — PR #26701 (braintree bump) shadow comment: - Showed 47 "only in Scalpel" with a ⚠️ badge — 28 of those were already in `EXCLUSION_LIST` - "Modules Scalpel would test" summary said **(19)** but the list body had **43 entries** (24 extra from `EXCLUSION_LIST`) ## Fix Apply `EXCLUSION_LIST` symmetrically to the Scalpel side in `writeScalpelComparison()`: 1. Build `excl_set_cmp` from `EXCLUSION_LIST` once at function entry 2. Filter `scalpel_sorted` through `excl_set_cmp` before the `comm` set-diff 3. Recompute `scalpel_total` from the filtered list (so the summary count is correct) 4. Skip excluded modules when iterating `scalpel_would_test` for the comment body (so header count matches list) No logic change to test execution — this is display-only. _Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
