gnodet-bot commented on code in PR #26330: URL: https://github.com/apache/camel/pull/26330#discussion_r4061556162
########## .github/workflows/dep-check.yml: ########## @@ -0,0 +1,126 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: 'Dependency Analysis' + +on: + pull_request: + branches: + - main + paths-ignore: + - .claude-plugin/** + - .idea/** + - .github/** + - .oss-ai-helper-rules/** + - AGENTS.md + - README.md + - SECURITY.md + - Jenkinsfile + - Jenkinsfile.* + - NOTICE.txt + +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +permissions: + contents: read + +jobs: + dep-check: + if: github.repository == 'apache/camel' + name: Dependency Analysis (non-blocking) + runs-on: ubuntu-latest + continue-on-error: true + env: + # Modules excluded from analysis — kept in one place so both the compile and analysis steps stay in sync. + # See comments in the compile step below for the exclusion rationale. + # Also update docs/main/modules/contributing/pages/building.adoc + # when changing the pilot-plugin version (0.4.0 below). + EXCLUDED_MODULES: '!bom,!components/camel-spring-parent/camel-spring-xml,!components/camel-test/camel-test-spring-junit5,!components/camel-test/camel-test-spring-junit6' + steps: + - name: Checkout + uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 + with: + ref: ${{ github.event.pull_request.head.sha }} Review Comment: 💡 **Nit — pom.xml sync reference dropped:** The comment added in ef0b26 to track all three version locations was narrowed to only mention `building.adoc`. The `pom.xml` `<pluginManagement>` entry (version 0.4.0 is still there in the diff) is also a sync point: when invoking via the short form `mvn pilot:dependencies -Pdep-check` (no explicit `groupId:artifactId:version` qualifier), Maven resolves the version from pluginManagement. A developer using the short form locally would silently get the outdated version if it drifts. ```suggestion # Also update pom.xml <pluginManagement> and docs/main/modules/contributing/pages/building.adoc ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
