gnodet-bot commented on code in PR #26676: URL: https://github.com/apache/camel/pull/26676#discussion_r4066303254
########## components/camel-mail/src/main/docs/mail-component.adoc: ########## @@ -299,14 +299,16 @@ cannot be overridden by message headers: [options="header"] |=== -| Option | Default | Effect when set to `false` -| `useHeaderRecipients`| `true` | Endpoint URI to/cc/bcc always used; To/CC/BCC headers ignored. -| `useHeaderFrom` | `true` | Endpoint URI from always used; From/Sender headers ignored. -| `useHeaderSubject` | `true` | Endpoint URI subject always used; Subject header ignored. -| `useHeaderReplyTo` | `true` | Endpoint URI replyTo always used; Reply-To header ignored. +| Option | Default | Effect when set to `true` +| `useHeaderRecipients`| `false` | Message To/CC/BCC headers can override the endpoint URI recipients. +| `useHeaderFrom` | `false` | Message From/Sender headers can override the endpoint URI sender. +| `useHeaderSubject` | `false` | Message Subject header can override the endpoint URI subject. +| `useHeaderReplyTo` | `false` | Message Reply-To header can override the endpoint URI replyTo. |=== -All four default to `true` so existing behaviour is preserved. Example: +All four default to `false`. Set to `true` to let message headers override the endpoint configuration. Review Comment: Prior finding (raised in earlier review) still not addressed. The summary sentence here is correct. But the surrounding prose at lines 293–298 (not changed by this PR) says the four options "let you **lock** the endpoint configuration so it **cannot be overridden** by message headers" — this is inverted with `defaultValue=false`. With the default being `false`, headers are already blocked by default — these options **enable** (unlock) header overrides, not lock them. Please fix lines 293–298 to say something like: > By default, the endpoint URI configuration is always used — message headers cannot override recipients, sender, subject, or reply-to. Four opt-in options let you **allow** message headers to take precedence: This must be fixed in the same commit, not a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
