gnodet-bot commented on code in PR #26732:
URL: https://github.com/apache/camel/pull/26732#discussion_r4069910543
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/EndpointChecks.java:
##########
@@ -282,6 +282,16 @@ static String missingInRuntime(CamelCatalog catalog,
String scheme) {
/** Options models write that the component does not have, and what the
component does instead. */
static final Map<String, String> INVENTED_OPTIONS = Map.ofEntries(
+ // CAMEL-24888: the path parameters of an OpenAPI operation are
headers of the same name
+ Map.entry("rest-openapi:path",
+ "a path parameter of the operation, {sku} in /stock/{sku},
comes from a header of the same name: add"
+ + " setHeader: {name: sku, ...}
before the call, the operation's path is in the contract"),
+ Map.entry("rest-openapi:pathParameters",
+ "a path parameter of the operation comes from a header of
the same name: add setHeader: {name: sku,"
+ + " ...} before the
call"),
+ Map.entry("rest-openapi:queryParameters",
+ "a query parameter of the operation comes from a header of
the same name: add setHeader before the"
+ + " call"),
Review Comment:
💡 **Inconsistent hint detail.** The `path` and `pathParameters` entries both
give a concrete `{name: sku, ...}` example; this one stops at "add setHeader
before the call" with no example. Consider aligning:
```suggestion
Map.entry("rest-openapi:queryParameters",
"a query parameter of the operation comes from a header
of the same name: add setHeader: {name: page,"
+ " ...} before the
call"),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
