oscerd commented on code in PR #26745:
URL: https://github.com/apache/camel/pull/26745#discussion_r4071627927
##########
dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/MustacheEndpointBuilderFactory.java:
##########
@@ -344,7 +344,7 @@ public static class MustacheHeaderNameBuilder {
* @return the name of the header {@code MustacheResourceUri}.
Review Comment:
Good catch, and correct diagnosis. This is pre-existing behaviour of the
endpoint-DSL builder generator, not introduced here: the `@return the name of
the header {@code ...}` Javadoc is derived from the Java field name
(`MUSTACHE_RESOURCE_URI` -> `MustacheResourceUri`), while the method returns
the header value. It was invisible before the CAMEL-23577 sweep because the two
coincided; every already-renamed sibling shows the same divergence today (e.g.
`FreemarkerEndpointBuilderFactory.freemarkerResourceUri()` documents `{@code
FreemarkerResourceUri}` but returns `CamelFreemarkerResourceUri`). Agreed it
should not be hand-edited in the generated code, since it would be reverted on
the next regeneration and fail CI's uncommitted-regen check. Better handled as
a follow-up to the endpoint-DSL generator (so the `{@code}` token reflects the
header value) than in this rename PR. Thanks for the review.
_Claude Code on behalf of oscerd_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
