squakez commented on code in PR #6841: URL: https://github.com/apache/camel-k/pull/6841#discussion_r4079467124
########## e2e/cert-manager/setup/setup.sh: ########## @@ -26,5 +26,13 @@ kubectl wait --for=condition=available deployment/cert-manager -n cert-manager - kubectl wait --for=condition=available deployment/cert-manager-webhook -n cert-manager --timeout=$TIMEOUT kubectl wait --for=condition=available deployment/cert-manager-cainjector -n cert-manager --timeout=$TIMEOUT -# Install a self-signed ClusterIssuer for test purposes -kubectl apply -f $SCRIPT_DIR/cluster-issuer.yaml +# Install a self-signed ClusterIssuer for test purposes (retrying until webhook is ready to accept connections) Review Comment: I don't think this would be a proper way to solve. Ideally we need to wait until some condition apply, not polling in a loop for sure. In any case, this was likely a transient issue and it is not related with this specific PR, so, a better approach is to open an issue reporting the problem and tackle that in a separate PR. Please, remove from this PR and we can restart any failing check that is not related to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
