gnodet-bot commented on PR #26758:
URL: https://github.com/apache/camel/pull/26758#issuecomment-5792655538
**Re-review after `CHANGES_REQUESTED` — all findings resolved.**
**Finding 1 — `EVALUATED_PATH` entries: ✅ Addressed**
`xslt`, `xquery`, `mybatis`, `sql`, `elsql`, `jdbc`, and `spring-jdbc` are
gone. The remaining three (`language`, `micrometer`, `opentelemetry-metrics`)
are correct — their producer evaluates the path per message. The new
`testAComponentWhosePathIsAnAddressIsReported` test confirms that
`xslt:styles/${header.style}.xsl` is now flagged correctly (xslt resolves its
stylesheet once, so a path expression needs `toD:`).
**Finding 2 — `DocBlocks.examples()` consolidation: ✅ Addressed**
Both `EipDocExamplesTest` and `CatalogDocExamplesTest` now delegate to
`DocBlocks.examples()`. Local `YAML_BLOCK` patterns and `Matcher` loops are
gone from both test classes. The `\s*` in the consolidated pattern is a correct
generalisation that handles both the strict `\n----` and the
whitespace-tolerant `\s*\n----` variants.
**Finding 3 — Example counter 0-indexed: ✅ Addressed**
Old code: `"example " + n` where `n` started at 0 → first route was "example
0". New code: `"example " + (n + 1)` → first route is "example 1". Fixed
consistently in both test classes.
**Additional checks (new code):**
- `MARKER_LOOKBEHIND = 200`: the marker appears 1–2 lines before
`[source,yaml]`, so 200 chars of context is more than sufficient.
- `:#${...}` SQL-parameter exemption: verified arithmetically —
`head.startsWith(":#", start - 2)` correctly catches `sql:SELECT …
:#${body.itemId}` and returns `null`.
- Cross-module access: `camel-yaml-dsl-validator` is already a compile-scope
dependency of `camel-jbang-core`, so `DocBlocks` is accessible without a pom
change.
- `checkDynamicUri` placement inside `if (errors.isEmpty())` is intentional
and consistent with `checkSimpleSyntaxInScripts` — don't emit the `toD:` hint
when the YAML already has schema errors.
_This review was generated by an AI agent, Hermès on behalf of @gnodet._
<!-- reviewer: gnodet-bot -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
