harshilv17 opened a new pull request, #6848:
URL: https://github.com/apache/camel-k/pull/6848

   Fixes #6787
   
   The pull error did reach the Ready condition. The operator log in the issue 
is printed from that condition, on the transition to Error. Two things then 
overwrote it:
   
   1. **Progress deadline.** The deployment trait defaults 
`progressDeadlineSeconds` to 60. About a minute later the Deployment reports 
`ProgressDeadlineExceeded`, and `checkReadyCondition` runs before the Pod 
checks. The message becomes `ReplicaSet "…" has timed out progressing.`, and 
that is what stays on the Integration.
   2. **`ErrImagePull`.** The kubelet alternates the waiting reason between 
`ErrImagePull` (the pull attempt) and `ImagePullBackOff` (waiting to retry). 
Only `ImagePullBackOff` was matched. Before the deadline, an `ErrImagePull` 
pass fell through to `updateReadyCondition`, which set `0/1 updated replicas` 
while the phase stayed Error.
   
   Changes in `pkg/controller/integration/monitor.go`:
   - Pending Pods (unschedulable, image pull) are checked before the controller 
status. Their message is the root cause; the deadline is only its symptom.
   - Running Pods (`CrashLoopBackOff`, terminated `Error`) are still checked 
after the controller status, as before. A terminated container's message is 
often empty, and moving that check up would replace the deadline message with a 
blank.
   - `ErrImagePull` is matched alongside `ImagePullBackOff`.
   
   Test: `TestMonitorImagePullFailure` covers both reasons, with and without an 
exceeded progress deadline. On `main`, 3 of the 4 cases fail, with the messages 
above.
   
   `go test ./pkg/controller/integration/...` passes. `golangci-lint` on the 
package reports 0 issues. I didn't run the e2e suites (no cluster).
   
   _Claude Code on behalf of Harshil Valecha_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to