gnodet-bot commented on code in PR #26821:
URL: https://github.com/apache/camel/pull/26821#discussion_r4090585586
##########
docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc:
##########
@@ -13,6 +13,28 @@ See the xref:camel-upgrade-recipes-tool.adoc[documentation]
page for details.
== Upgrading Camel 4.22 to 4.23
+=== camel-core - Exchange Pooling deprecated
+
+Exchange pooling (`exchangeFactory=pooled`) is deprecated and will be removed
in a future release.
+The following classes are deprecated:
+
+- `org.apache.camel.PooledExchange`
+- `org.apache.camel.support.DefaultPooledExchange`
+- `org.apache.camel.impl.engine.PooledExchangeFactory`
+- `org.apache.camel.impl.engine.PooledProcessorExchangeFactory`
+- `org.apache.camel.processor.PooledExchangeTaskFactory`
+- `org.apache.camel.processor.PooledTaskFactory`
Review Comment:
⚠️ `CamelInternalPooledTaskFactory` is deprecated in the code (and listed in
the PR description) but is missing here. Add it to keep the docs consistent:
```suggestion
- `org.apache.camel.processor.PooledTaskFactory`
- `org.apache.camel.impl.engine.CamelInternalPooledTaskFactory`
```
##########
core/camel-main/src/main/java/org/apache/camel/main/DefaultConfigurationConfigurer.java:
##########
@@ -166,6 +166,9 @@ public static void configure(CamelContext camelContext,
DefaultConfigurationProp
beanIntrospection.afterPropertiesConfigured(camelContext);
if ("pooled".equals(config.getExchangeFactory())) {
+ LOG.warn(
+ "Exchange pooling (exchangeFactory=pooled) is deprecated
and will be removed in a future release."
+ + " Please remove the
'camel.main.exchange-factory=pooled' configuration.");
Review Comment:
💡 String concatenation with `+` between two literals produces an unnecessary
intermediate string (even if javac collapses it, it's still noisy). Use a
single string:
```suggestion
LOG.warn(
"Exchange pooling (exchangeFactory=pooled) is deprecated
and will be removed in a future release."
+ " Please remove the
'camel.main.exchange-factory=pooled' configuration.");
```
Alternatively, just join them into one literal — no functional difference,
purely style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
