gnodet-bot commented on code in PR #26813:
URL: https://github.com/apache/camel/pull/26813#discussion_r4090836277
##########
core/camel-api/src/main/java/org/apache/camel/spi/PropertyConfigurer.java:
##########
@@ -37,6 +37,23 @@
*/
public interface PropertyConfigurer {
+ /**
+ * Optionally binds a value before resolving bean or class references.
Property placeholders have already been
Review Comment:
📝 **Javadoc inaccuracy:** The statement "Property placeholders have already
been resolved" is only true when `doSetPropertyValue()` is called with
`placeholder=true`. When `placeholder=false` (e.g. a raw programmatic bind),
the value reaches `configureRaw` without placeholder resolution. The Javadoc
misleads third-party `PropertyConfigurer` implementors who may write code that
assumes `{{...}}` tokens are always expanded before this method is called.
Suggested fix:
```suggestion
* Optionally binds a value before resolving bean or class references.
Property placeholders
* are resolved before this call when placeholder resolution was
requested by the caller.
* This allows an option that owns reference resolution and lifecycle to
retain the reference text.
* Returning false leaves the normal binding behavior unchanged.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
