davsclaus commented on PR #26822:
URL: https://github.com/apache/camel/pull/26822#issuecomment-5809718566
Closing in favour of CAMEL-24984 (#26824), which supports `!` as a negation
prefix and makes this message wrong.
The shapes this PR added a hint for now work, so the hint would fire less
and say the wrong thing where it still does:
| expression | with #26824 |
|---|---|
| `!${body.isEmpty()}` | evaluates |
| `${!body.isEmpty()}` | evaluates |
| `${body != null && !body.isEmpty()}` | evaluates |
| `${body != null && !${body.isEmpty()}}` | evaluates |
Where a `!` still cannot be read — `${a} && !x`, a name that is not a `${ }`
function — the useful advice is no longer "compare it instead" but "write it as
`!${x}`". That reworded hint is part of #26824, together with a test, so
nothing from this PR is lost.
Thanks for the review that got it here: the finding about the vacuous
negative test was right, and testing each shape against the runtime is what
showed that the nesting was never the cause — the `!` was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
