davsclaus commented on PR #26824:
URL: https://github.com/apache/camel/pull/26824#issuecomment-5809817350
Both findings addressed in `d6e10af7fd4f` (and @gnodet's second regen
merged).
**Missing `init()` — correct, fixed.** `UnaryExpression.createNotExpression`
now forwards `init` like `SimpleFunctionExpression.createNegatedExpression`
does. Same mistake in both places.
Worth recording what it actually was, since the two paths behaved
differently: on the `${!...}` path the inner function is built outside the node
tree, and without `init` it threw exactly the NPE predicted —
`OgnlExpressionBuilder$7.evaluate`, where the `private Language bean` field is
only set in `init`. On the `!${...}` operator path the inner expression is
reached through `left.createExpression(...)`, and it evaluates correctly with
or without the override: I removed the override, rebuilt and re-ran, and all 10
tests still passed, including `!${body.isEmpty()}` which is OGNL-backed.
So on the operator path it is a latent inconsistency rather than an active
fault with the functions covered. Fixed anyway — the two should not differ, and
relying on the node tree to initialise it is not something a reader should have
to know.
**Doc build — fixed properly this time.** The earlier fix moved the examples
into a table but left `${body}` in prose, which is the form Asciidoctor
expands: the warning is specifically `skipping reference to missing attribute:
body`, and `{body}` is a valid attribute name while `{date:now:HH}` and
`{header.n > 3}` are not, which is why the surrounding prose was never
affected. Every `${` outside a source block in the new section is now escaped
as `\${`, and the catalog copy is synced byte-for-byte.
`SimpleNotOperatorTest` 10 tests and `SimpleSyntaxHintsTest` 24 tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
