gnodet-bot commented on code in PR #26832:
URL: https://github.com/apache/camel/pull/26832#discussion_r4091257377
##########
.github/workflows/pr-build-main.yml:
##########
@@ -235,3 +266,24 @@ jobs:
name: ci-comment
path: ci-comment-artifact/
overwrite: true
+ # Dependency analysis runs only on JDK 25 (the primary CI JDK) and only
on full builds
+ # (not /component-test targeted builds). The regen.sh step above has
already compiled the
+ # full reactor and installed all JARs into the local .m2 repository, so
pilot:dependencies
+ # can run directly without re-compiling or installing SNAPSHOT stubs —
the compiled classes
+ # and resolved artifacts are already available on disk.
+ - name: Run dependency analysis
+ if: matrix.java == '25' && !inputs.skip_full_build
Review Comment:
**Bug: missing `${{ }}` expression wrapper**
Every other `if:` condition referencing `inputs.*` in this file uses the
`${{ }}` wrapper (lines 119, 163, 168, 192). Without it, the YAML parser treats
`!inputs.skip_full_build` as a YAML tag — `!` is a YAML tag indicator, not
boolean negation when outside an expression block. The step condition will not
evaluate as intended.
```suggestion
if: ${{ matrix.java == '25' && !inputs.skip_full_build }}
```
##########
.github/workflows/pr-build-main.yml:
##########
@@ -235,3 +266,24 @@ jobs:
name: ci-comment
path: ci-comment-artifact/
overwrite: true
+ # Dependency analysis runs only on JDK 25 (the primary CI JDK) and only
on full builds
+ # (not /component-test targeted builds). The regen.sh step above has
already compiled the
+ # full reactor and installed all JARs into the local .m2 repository, so
pilot:dependencies
+ # can run directly without re-compiling or installing SNAPSHOT stubs —
the compiled classes
+ # and resolved artifacts are already available on disk.
+ - name: Run dependency analysis
+ if: matrix.java == '25' && !inputs.skip_full_build
+ continue-on-error: true
+ run: |
+ mvn eu.maveniverse.maven.plugins:pilot-plugin:0.4.0:dependencies \
+ -Pdep-check -Dpilot.skipTestScope=true -Dlicense.skip \
+ --pl "$DEP_CHECK_EXCLUDED_MODULES" \
+ --no-transfer-progress --batch-mode \
+ 2>&1 | tee dep-check-output.txt
+ - name: Upload dependency analysis report
+ if: (matrix.java == '25' && !inputs.skip_full_build) && always()
Review Comment:
**Same missing `${{ }}` wrapper**
Same issue as the step above. Additionally, when mixing `always()` with
other conditions, `always()` should come first — GitHub Actions evaluates
status functions before other conditions; placing it at the end means the step
may still be skipped when the preceding expressions are false.
Since `continue-on-error: true` on the prior step already prevents the job
from entering the failure state, `always()` is not needed here — use the same
form as the step above:
```suggestion
if: ${{ matrix.java == '25' && !inputs.skip_full_build }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
