gnodet commented on code in PR #26792:
URL: https://github.com/apache/camel/pull/26792#discussion_r4092426339
##########
core/camel-core-xml/pom.xml:
##########
@@ -42,7 +42,19 @@
<artifactId>camel-core-engine</artifactId>
</dependency>
+ <!-- required logging api dependency -->
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
+
<!-- testing -->
+ <!-- test -->
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-core-engine</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
The duplicate entry has already been removed in commit 00005e29c90a2 (the
commit just before this one).
##########
core/camel-yaml-io/pom.xml:
##########
@@ -56,6 +51,18 @@
</dependency>
<!-- testing -->
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-core-model</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-util</artifactId>
+ </dependency>
Review Comment:
Fixed in cec4ea5feb41ecc4a71da40c61e8a0db3cb221b6 — moved camel-api,
camel-core-model, and camel-util above the `<!-- testing -->` comment.
##########
tooling/openapi-rest-dsl-generator/pom.xml:
##########
@@ -94,6 +90,31 @@
</dependency>
<!-- test -->
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-core-engine</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-support</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-util</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-core-model</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </dependency>
Review Comment:
Fixed in cec4ea5feb41ecc4a71da40c61e8a0db3cb221b6 — moved camel-api,
camel-support, camel-util, camel-core-model, and slf4j-api above the `<!-- test
-->` comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
