davsclaus commented on PR #26916: URL: https://github.com/apache/camel/pull/26916#issuecomment-5849124171
Closing: not worth the duplication. CAMEL-24869 already detects this at authoring time, and the benchmark evidence I filed the issue on turned out to be about H2's upsert dialect rather than the parameter syntax — the validator had already told the model, and the model had already fixed it. What this would have added is only the runtime path, for someone hand-writing a route without the validator. That reach does not justify a second implementation of the same detection, which cannot be shared (camel-sql cannot depend on camel-jbang-core). The work stays on `fix/CAMEL-25039` if the runtime warning is ever wanted: `SqlHelper.findParameterMissingPlaceholder` with 11 tests for the false-positive cases (a Postgres `::cast`, a time literal, a colon inside a quoted literal, the `:#in:list` form, a non-default `placeholder`), and it fires on none of the 300 existing camel-sql tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
