davsclaus commented on code in PR #26890:
URL: https://github.com/apache/camel/pull/26890#discussion_r4112510788
##########
components/camel-hivemq/src/main/java/org/apache/camel/component/hivemq/HiveMQConfiguration.java:
##########
@@ -75,6 +77,12 @@ public class HiveMQConfiguration implements Cloneable {
@Metadata(label = "security", secret = true)
private String password;
+ /**
+ * To use a custom HeaderFilterStrategy to filter headers.
+ */
+ @UriParam(label = "advanced", description = "To use a custom
HeaderFilterStrategy to filter headers.")
Review Comment:
If the consumer change is reverted (as it needs to be, since the component's
own `CamelHiveMQ*` headers must not be filtered), this option has nothing to
act on: HiveMQ does not map MQTT5 user properties to headers. Users who
configure a strategy would see no effect. I'd suggest dropping the option until
user-property mapping exists. If it stays, other components usually use `label
= "filter"`, and the `description` attribute duplicates the Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
