davsclaus opened a new pull request, #26926: URL: https://github.com/apache/camel/pull/26926
Fixes [CAMEL-25045](https://issues.apache.org/jira/browse/CAMEL-25045): bugs in the Java DSL builders (`ProcessorDefinition`, `ExpressionClauseSupport`) found in a deep review. Each fix has a test in `ProcessorDefinitionBuilderEdgeCasesTest` that fails without it. 1. **`choice().note(...)` fails with `StackOverflowError`.** When the choice has no when/otherwise yet, `note()` called itself instead of `setNote()` (from CAMEL-22576). 2. **`throttle(Expression, long correlationExpressionKey)` ignores the key.** It used the maximum-requests expression as the correlation expression too, a regression in 4.19. 3. **`onException(e1, e2, e3)` in a route configuration drops the third exception.** It passed `e2` twice (from CAMEL-22529). 4. **`simple(text, resultType, pretty, trimResult)` ignores `trimResult`.** 5. **`endDoTry()` from a block inside `doCatch`/`doFinally` fails with `ClassCastException`.** For example `doCatch(E.class).filter(...).to(...).endDoTry().doFinally()`: `end()` returns the catch, not the try. 6. **`enrichWith(EndpointProducerBuilder)` makes the uri a constant.** Its sibling overloads use a simple expression, so `enrichWith(direct("${header.target}"))` was not dynamic. 7. **The `type:` prefix of `bean(...)` only works in `bean(Object, String method)`.** `bean("type:com.foo.MyBean")` and the `BeanScope` variants looked up a bean with that name (from CAMEL-19244). The whole `camel-core` test suite passes. _Claude Code on behalf of Claus Ibsen_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
