allthingssecurity commented on PR #26793:
URL: https://github.com/apache/camel/pull/26793#issuecomment-5855362249
Done in 97f00dd10 (new commit on top, no rebase):
- `testReplyBeingCopiedWhenTimeoutOccurs` now uses `timeout=1000`, as the
disruptor test does.
- The seda entry in the 4.23 upgrade guide ("an interrupted producer fails
the exchange") now also says that a reply that arrives after the producer timed
out, or was interrupted, is ignored, and that a reply which is already being
copied when the timeout or the interrupt occurs is returned.
The test still exercises the race with the larger timeout. With
`SedaProducer` as it is on main (without this PR's fix) and `timeout=1000`,
`testReplyBeingCopiedWhenTimeoutOccurs` fails after about 1.1 s with "Producer
returned while the reply was copied into the exchange"
(`testReplyBeingCopiedWhenInterrupted` fails the same way). With the fix, all 3
tests in `SedaTimeoutLateReplyTest` pass, and `*Seda*` in camel-core (built
together with camel-seda) passes: 145 tests, 0 failures. `git merge-tree` shows
no conflicts against current main or against #26913.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
